Re: CVS 1.11.2 Released!

[Matthew M. Ogilvie]

>
>Message: 3
>Date: Mon, 20 May 2002 14:55:29 -0400
>From: Derek Robert Price <oberon@umich.edu>
>Subject: Re: CVS 1.11.2 Released!
>To: Noel Yap <yap_noel@yahoo.com>
>Cc: info-cvs@gnu.org, bug-cvs@gnu.org
>
>Noel Yap wrote:
>
>>--- Derek Robert Price <oberon@umich.edu> wrote:
>>
>>>Noel Yap wrote:
>>>
>>>>Grrr!  It looks like the advisory locks patch still
>>>>didn't make it in.  I think the patch have all the
>>>>necessary requisites (doc and test patch).  Is it
>>>>still missing something?
>>>>
>>>>Noel
>>>>
>>>I've fallen a little bit behind on the email lists,
>>>I won't get into 
>>>why, but I just found your patch on SourceForge. 
>>>I'll try and find time 
>>>to take a look at it so that you can at least get
>>>feedback and maybe get 
>>>the patch into the next release.
>>>
>>>Thanks for your patience.
>>>
>>
>>Hey, so long as it's not being ignored outright ...
>>:-)
>>
>>The LAG (latest and greatest) of this patch was
>>submitted by Matt Ogilvie (who added docs and tests). 
>>Just to be sure you get the right one, here is the
>>URL:
>>https://sourceforge.net/tracker/index.php?func=detail&aid=471046&group_id=4680atid=304680
>>
>>Thanks,
>>Noel
>>
>
>The addition of documentation and test cases is great, but this patch is 
>still way too big.  I'll keep trying to deal with it if somebody will 
>chop it into little bite size chunks, one bug fix or feature, its doc, 
>and its tests per chunk.
>
>For instance, the bug fixes Mathew Ogilvie mentions he made as he was 
>working on this should have their own patches.  Making edit report 
>editors should be in its own patch.  Advisory locks should have its own 
>patch, possibly several when it makes sense, but I didn't read enough to 
>give further advice.  The sockPlayer separation is nice too - keep it 
>separate.
>
>Sorry about that, but I really don't have the time for so much unpaid 
>work at the moment.
>
>Derek
>
>-- 
>

Derek,

It is hard to be certain, but your message leaves me with the impression
that you were looking at an older version of the patch.  There
are several versions at the web page, you want the latest version,
which is currently editCheck-25feb2002.diff:

https://sourceforge.net/tracker/index.php?func=detail&aid=471046&group_id=4680&atid=304680

The 25feb2002 version includes much of what you ask for: sockPlayer
is gone completely, (you can always get it out the older version if
you want [might be useful when overhauling the test
suite??]), and the patch itself is split into logically seperate
subpatches within the file.

Take your time - as Noel said "Hey, so long as it's not being
ignored outright ...".  Thanks for looking at it, though...

--
Matthew Ogilvie                [mmogilvi@flashmail.com]