Re: [PATCH] fix off-by-one in substring

[Mario Domenech Goulart]

Hi,

On Mon, 15 Apr 2024 12:50:44 +0200 felix.winkelmann@bevuta.com wrote:

> This patch addresses #1823, which was caused by an off-by-one error
> in the check of the end-index, which is exclusive. Thanks to "siiky" for
> reporting this.

Thanks siiky and Felix.  I've pushed the patch.

I think it actually fixes #1835, not #1823, right?  At least I tested it
against the utf8 issue and it does fix the problem (I've also been able
to reproduce the problem _without_ the patch). :-)

In fact #1835 points to another problem: the utf8 egg is not reflecting
the error in tests in the exit code of run.scm.  The attached patch
should fix that.  Alex: could you please take a look?  If that looks ok,
I can make a bugfix release of utf8 if you want (bumping the patch
version -- I checked and there's no diff between trunk and 3.6.3).  Just
let me know if you want me to do that.

All the best.
Mario
-- 
http://parenteses.org/mario

utf8.diff
Description: Text Data