RE: [PATCH] Fix for Hashtable contains blowing up the stack

[Mark Wielaard]

Hi,

On Sat, 2003-11-22 at 13:06, Jeroen Frijters wrote:
> The fix is actually incorrect. containsValue() should call contains()
> because containsValue() is a new method (since 1.2) and contains()
> exists since 1.0. Older code may have overridden contains() and this
> should work with newer code that calls containsValue().

Urgh. Yes, you are right. Wrote an additional test case for this:
gnu.testlet.java.util.Hashtable.ContainsHash (it currently fails).

> As I've argued before, in cases such as these (multiple virtual methods
> that do the same thing), we must use the same delegation as the Sun
> implementation to be compatible.

Problem is that this is not always easy to know.
So we depend on bug reports and then have to write a Mauve test if we
think that following such behavior is beneficial. But the "newer calls
older" is a guideline that will mostly work (I hope).

BTW. People might want the read what Jeroen wrote earlier about it:
http://weblog.ikvm.net/commentview.aspx/8b14c003-e16a-4e99-a52e-ad776cbb8cbf
His blog entires (and the people who comment on it) are very nice BTW.
I am always a bit sad when there is a week without a new entry.

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part