[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] config.guess: Use int
From: |
Zack Weinberg |
Subject: |
Re: [PATCH 1/1] config.guess: Use int |
Date: |
Wed, 03 Apr 2024 13:40:39 -0400 |
User-agent: |
Cyrus-JMAP/3.11.0-alpha0-333-gbfea15422e-fm-20240327.001-gbfea1542 |
On Wed, Apr 3, 2024, at 1:01 PM, Petr Vorel wrote:
> Although -Wmain-return-type is not considered as error (unlike
> -Wimplicit-int on gcc 14 and clang 16), but just a warning, let's fix it
> for the future.
>
> <stdin>:1:1: warning: return type of 'main' is not 'int' [-Wmain-return-type]
I agree we should make this change, but...
> - main()
> + int main()
please *don't* put the return type on the same line as the function name,
and change the argument list to `(void)` while you're touching this.
We want the end result to be
int
main (void)
> - int
> - main ()
> + int main ()
same here
zw