[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ELPA] New package: dict
From: |
Eshel Yaron |
Subject: |
Re: [ELPA] New package: dict |
Date: |
Mon, 15 May 2023 21:58:18 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Stephen Leake <stephen_leake@stephe-leake.org> writes:
> Eshel Yaron <me@eshelyaron.com> writes:
>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>>>> From: Eshel Yaron <me@eshelyaron.com>
>>>> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
>>>> Date: Fri, 12 May 2023 16:17:53 +0300
>>>>
>>>> Any thoughts/ideas?
>>>
>>> How about adding to dictionary.el a customizable function that
>>> dictionary-search would call instead of its default operation?
>>
>> Thanks, this would be a good way to expose the different behavior that I
>> want to add. However, my difficulty lies elsewhere. The issue I
>> brought up in my previous message is with implementing this behavior
>> without introducing unnecessary code duplication to dictionary.el.
>>
>> In short, we need two things: a way to obtain a word's definition and a
>> way to obtain dictionary matches given some input (for completion).
>> dictionary.el does these things already, but in way that's too coupled
>> with its user interface to admit reuse for my purposes. So the question
>> is whether to add the needed stuff from Dict to dictionary.el and accept
>> some code duplication, or try to refactor the parts of dictionary.el
>> that communicate with the dictionary server to provide a cleaner API.
>
> Maybe you can rewrite the higher-level code in dictionary.el to depend
> on the lower-level code in dict.el (while combining them into one file).
That'd definitely make it easier to integrate new functionality, but I
think it would be quite hard to do without risking breaking existing
dictionary.el features. For now I avoided making extensive changes.
--
Best,
Eshel
- Re: [ELPA] New package: dict, (continued)
- Re: [ELPA] New package: dict, Eshel Yaron, 2023/05/21
- Re: [ELPA] New package: dict, Eshel Yaron, 2023/05/25
- Re: [ELPA] New package: dict, Philip Kaludercic, 2023/05/25
- Re: [ELPA] New package: dict, Eli Zaretskii, 2023/05/26
- Re: [ELPA] New package: dict, Rudolf Adamkovič, 2023/05/26
- Re: [ELPA] New package: dict, Eshel Yaron, 2023/05/26
- Re: [ELPA] New package: dict, Philip Kaludercic, 2023/05/18
- Re: [ELPA] New package: dict, Eshel Yaron, 2023/05/18
- Re: [ELPA] New package: dict, Philip Kaludercic, 2023/05/18
- Re: [ELPA] New package: dict, Stephen Leake, 2023/05/14
- Re: [ELPA] New package: dict,
Eshel Yaron <=
Re: [ELPA] New package: dict, Philip Kaludercic, 2023/05/11
Re: [ELPA] New package: dict, Richard Stallman, 2023/05/13
Re: [ELPA] New package: dict, Eshel Yaron, 2023/05/14