Re: [gnugo-devel] GNU Go 3.3.23

[Gunnar Farneback]

Dan wrote:
> I don't think there are any changes since 3.3.22 that could
> break compilation under OS X and Windows. However we'd
> still like to hear if you compile it successfully on
> other platforms. (How about solaris?)

I've tested compilation on Sparc/Solaris/gcc, Sparc/Solaris/cc,
Alpha/Linux/gcc, AIX/gcc, HP-UX/gcc, IRIX/gcc, and Cray/cc. There are
a few warnings on some of the architectures, but nothing serious (and
some weird warnings almost certainly indicating a slightly broken
compilation environment). I've only partially run regressions, but
those show no unexpected results.

A patch for a couple easily solved warnings is appended.

/Gunnar

PS. I'll be on vacation until next Sunday (July 27) without any
internet connection. GNU Go will be missing on NNGS during this time.

Index: engine/cache.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/cache.c,v
retrieving revision 1.24
diff -u -r1.24 cache.c
--- engine/cache.c      4 Jun 2003 12:48:49 -0000       1.24
+++ engine/cache.c      17 Jul 2003 11:11:47 -0000
@@ -119,10 +119,11 @@
 
   /* Data about the table itself. */
   fprintf(outfile, "Dump of hashtable\n");
-  fprintf(outfile, "Total size: %d\n", table->node_limit - table->all_nodes);
+  fprintf(outfile, "Total size: %d\n", (int) (table->node_limit
+                                             - table->all_nodes));
   fprintf(outfile, "Size of hash table: %d\n", table->hashtablesize);
   fprintf(outfile, "Number of positions in table: %d\n",
-         table->free_node - table->all_nodes);
+         (int) (table->free_node - table->all_nodes));
 
   /* Data about the contents. */
   for (i = 0; i < table->hashtablesize; ++i) {
Index: patterns/dfa.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/dfa.c,v
retrieving revision 1.30
diff -u -r1.30 dfa.c
--- patterns/dfa.c      22 Feb 2003 10:54:24 -0000      1.30
+++ patterns/dfa.c      17 Jul 2003 11:11:49 -0000
@@ -1778,7 +1778,7 @@
 void
 dfa_patterns_add_pattern(dfa_patterns *patterns, const char *string, int index)
 {
-  dfa_pattern *pattern;
+  dfa_pattern *pattern = NULL;
 
   if (index == patterns->num_patterns - 1) {
     assert(patterns->last_pattern);
Index: patterns/mkpat.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/mkpat.c,v
retrieving revision 1.121
diff -u -r1.121 mkpat.c
--- patterns/mkpat.c    27 May 2003 08:48:24 -0000      1.121
+++ patterns/mkpat.c    17 Jul 2003 11:11:50 -0000
@@ -2196,8 +2196,8 @@
 /* ================================================================ */
 
 #define CORNER_DB_SIZE(patterns, variations)\
-  (( patterns * sizeof(struct corner_pattern)\
-   + variations * sizeof(struct corner_variation)) / 1024)
+  ((int) (( patterns * sizeof(struct corner_pattern)\
+   + variations * sizeof(struct corner_variation)) / 1024))
 
 static struct corner_variation_b corner_root;
 static int second_corner_offset[MAXPATNO];