Re: [gnugo-devel] 2 questions

[Paul Pogonyshev]

I wrote:
> P.S. speaking of which, it seems to be standard to write help message
>      (gnugo --help) to stdout, not stderr; any objections to changing it?

The patch below changes it for GNU Go and every tool i remembered about.
You can see that (most) programs (at least GNU programs) write help
messages to stdout by testing

        ls --help > /dev/null

I think i wanted to do `./gnugo --help | grep something' one day, but
that failed.  After this patch, such things will work.

Paul



Index: interface/main.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/interface/main.c,v
retrieving revision 1.90
diff -u -p -r1.90 main.c
--- interface/main.c    24 Jan 2004 04:04:56 -0000      1.90
+++ interface/main.c    24 Jan 2004 21:38:59 -0000
@@ -54,7 +54,7 @@
 #include "sgftree.h"
 #include "random.h"
 
-static void show_copyright(void);
+static void show_copyright(FILE *where);
 static void show_version(void);
 static void show_help(void);
 static void show_debug_help(void);
@@ -896,7 +896,7 @@ main(int argc, char *argv[])
        break;
        
       case OPT_SHOWCOPYRIGHT: 
-       show_copyright();
+       show_copyright(stdout);
        return EXIT_SUCCESS;
        break;
        
@@ -975,7 +975,7 @@ main(int argc, char *argv[])
   if (!quiet) {
     fprintf(stderr, "\n");
     show_version();
-    show_copyright();
+    show_copyright(stderr);
   }
   
   /* Start random number seed. */
@@ -1383,7 +1383,7 @@ main(int argc, char *argv[])
 static void
 show_version(void)
 {
-  fprintf(stderr, "GNU Go Version %s\n", VERSION);
+  printf("GNU Go Version %s\n", VERSION);
 }
 
 
@@ -1527,6 +1527,7 @@ Debugging Options:\n\
    -r, --seed number             set random number seed\n\
    --gtp-dump-commands <file>    dump commands received in GTP mode\n\
 "
+
 #define USAGE_DEBUG2 "\
        --decide-string <string>  can this string live? (try with -o)\n\
        --decide-connection <str/str> can these strings connect? (try with 
-o)\n\
@@ -1581,35 +1582,33 @@ static void
 show_help(void)
 {
   set_depth_values(DEFAULT_LEVEL, 0);
-  fprintf(stderr, USAGE, level,
-         depth, backfill_depth, fourlib_depth, ko_depth, branch_depth,
-         backfill2_depth, break_chain_depth, superstring_depth, aa_depth, 
-         owl_distrust_depth, owl_branch_depth,
-         owl_reading_depth, owl_node_limit);
-  fprintf(stderr, USAGE1,
-         (float) DEFAULT_MEMORY, MIN_BOARD, MAX_BOARD, MAX_HANDICAP);
+  printf(USAGE, level,
+        depth, backfill_depth, fourlib_depth, ko_depth, branch_depth,
+        backfill2_depth, break_chain_depth, superstring_depth, aa_depth, 
+        owl_distrust_depth, owl_branch_depth,
+        owl_reading_depth, owl_node_limit);
+  printf(USAGE1,
+        (float) DEFAULT_MEMORY, MIN_BOARD, MAX_BOARD, MAX_HANDICAP);
 }
 
 
 static void
 show_debug_help(void)
 {
-  fprintf(stderr, USAGE_DEBUG USAGE_DEBUG2);
+  printf(USAGE_DEBUG USAGE_DEBUG2);
 }
 
 static void 
 show_debug_flags(void)
 {
-  fprintf(stderr, DEBUG_FLAGS);
+  printf(DEBUG_FLAGS);
 }
 
 static void
-show_copyright(void)
+show_copyright(FILE *where)
 {
-  fputs(COPYRIGHT, stderr);
+  fputs(COPYRIGHT, where);
 }
-
-
 
 
 /*
Index: interface/gtp_examples/twogtp.pike
===================================================================
RCS file: /cvsroot/gnugo/gnugo/interface/gtp_examples/twogtp.pike,v
retrieving revision 1.8
diff -u -p -r1.8 twogtp.pike
--- interface/gtp_examples/twogtp.pike  24 Jan 2004 04:04:56 -0000      1.8
+++ interface/gtp_examples/twogtp.pike  24 Jan 2004 21:39:19 -0000
@@ -1146,12 +1146,12 @@ main(int argc, array(string) argv)
                        basename(argv[0]));
 
   if (Getopt.find_option(argv, UNDEFINED, "help")) {
-    werror(help_message, basename(argv[0]));
+    write(help_message, basename(argv[0]));
     return 0;
   }
 
   if (Getopt.find_option(argv, UNDEFINED, "help-statistics")) {
-    werror(help_statistics_message);
+    write(help_statistics_message);
     return 0;
   }
 
Index: patterns/extract_fuseki.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/extract_fuseki.c,v
retrieving revision 1.20
diff -u -p -r1.20 extract_fuseki.c
--- patterns/extract_fuseki.c   24 Jan 2004 04:04:56 -0000      1.20
+++ patterns/extract_fuseki.c   24 Jan 2004 21:39:33 -0000
@@ -1119,7 +1119,7 @@ main(int argc, char *argv[])
   
   /* Check number of arguments. */
   if (argc < 6) {
-    fprintf(stderr, USAGE);
+    printf(USAGE);
     exit(EXIT_FAILURE);
   }
   
Index: patterns/joseki.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/joseki.c,v
retrieving revision 1.20
diff -u -p -r1.20 joseki.c
--- patterns/joseki.c   24 Jan 2004 04:04:57 -0000      1.20
+++ patterns/joseki.c   24 Jan 2004 21:39:34 -0000
@@ -387,7 +387,7 @@ main(int argc, char *argv[])
 
   /* Check number of arguments. */
   if (argc != 3) {
-    fprintf(stderr, USAGE);
+    printf(USAGE);
     exit(EXIT_FAILURE);
   }
 
Index: patterns/mkpat.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/mkpat.c,v
retrieving revision 1.130
diff -u -p -r1.130 mkpat.c
--- patterns/mkpat.c    24 Jan 2004 04:04:57 -0000      1.130
+++ patterns/mkpat.c    24 Jan 2004 21:40:53 -0000
@@ -2904,7 +2904,7 @@ main(int argc, char *argv[])
   }
 
   if (gg_optind >= argc) {
-    fputs(USAGE, stderr);
+    fputs(USAGE, stdout);
     exit(EXIT_FAILURE);
   }
 
Index: patterns/transpat.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/transpat.c,v
retrieving revision 1.8
diff -u -p -r1.8 transpat.c
--- patterns/transpat.c 24 Jan 2004 04:04:57 -0000      1.8
+++ patterns/transpat.c 24 Jan 2004 21:41:02 -0000
@@ -133,12 +133,11 @@ main(int argc, char *argv[])
   int  command = 0;
 
   if (argc < 2 || argc > 4) {
-    fprintf(stderr, 
-           "usage: %s command patnames [patfilename]\n\
+    printf("usage: %s command patnames [patfilename]\n\
 where\n\
     command     is one of 'flipleft' or 'normalize'\n\
     patnames    is a standard glob pattern (like EE*)\n\
-    patfilename is an optional filename\n", argv[0]);
+    patfilexname is an optional filename\n", argv[0]);
     exit(1);
   }
 
Index: regression/regress.pike
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/regress.pike,v
retrieving revision 1.6
diff -u -p -r1.6 regress.pike
--- regression/regress.pike     4 Nov 2003 10:13:56 -0000       1.6
+++ regression/regress.pike     24 Jan 2004 21:41:02 -0000
@@ -345,7 +345,7 @@ int main(int argc, array(string) argv)
     [string name, mixed value] = option;
     switch (name) {
       case "help":
-       werror(help_message, basename(argv[0]));
+       write(help_message, basename(argv[0]));
        return 0;
        break;