Re: [gnugo-devel] URL for regression changes

[Stéphane Nicolet]

Le 4 nov. 03, à 21:54, Gunnar Farneback a écrit :

> Stephane wrote (on August 7):
> > This patch for regress.awk adds a url display for
> > each unexpected fails and passes, which can be
> > used to quickly see what the problem is.
> > The default value for the url is at Trevor's site.
> > Is there a better default value?
>
> Actually I would rather not have a default at all. Hardwiring an URL
> into the regress script doesn't feel very robust.
> /Gunnar

Here is an updated patch, which uses the environment variable
GNUGO_REGRESSION_URL to (optionaly) display the regression
changes in regress.sh and eval.sh.

I have removed the default value pointing to Trevor's site
from the patch. To see the URLs, you'll have to set the
GNUGO_REGRESSION_URL environment variable of your system to
something usefull, for instance (in tcshrc syntax) :

   setenv GNUGO_REGRESSION_URL "http://www.public32.com/regress/?";


Hope this helps,
  Stéphane.



***************************


--- gnugo-3.5.4-cvs/regression/regress.sh   Tue Nov  4 22:57:06 2003
+++ gnugo-3.5.4/regression/regress.sh  Thu Jan 29 10:27:52 2004
@@ -18,7 +18,7 @@
 shift

 cd $srcdir
-$GNUGO --quiet "$@" --mode gtp < $tstfile \
-       | awk -f regress.awk tst=$tstfile
+"$GNUGO" --quiet "$@" --mode gtp < $tstfile \
+       | awk -f regress.awk tst=$tstfile url=$GNUGO_REGRESSION_URL

 # regress.sh ends here


--- gnugo-3.5.4-cvs/regression/eval.sh      Sat Jun 28 15:07:02 2003
+++ gnugo-3.5.4/regression/eval.sh     Sat Jan 31 00:23:42 2004
@@ -15,4 +15,4 @@
 options4=$5  # May be omitted  FIXME: Do multiple options better.

 $GNUGO --quiet $options1 $options2 $options3 $options4 --mode gtp 
<$tstfile |\
-       awk -f $RD/regress.awk tst=$tstfile verbose=1
+       awk -f $RD/regress.awk tst=$tstfile verbose=1 
url=$GNUGO_REGRESSION_URL


--- gnugo-3.5.4-cvs/regression/regress.awk  Thu Jun 20 19:05:46 2002
+++ gnugo-3.5.4/regression/regress.awk Thu Jan 29 17:53:49 2004
@@ -89,6 +89,9 @@
            print num " PASSED";
          else
            print num " unexpected PASS!";
+         if (url)
+           print "   "url""tst":"num;
+
        } else {
          if (verbose) {
            print num " passed";
@@ -105,6 +108,8 @@
        } else {
          if (verbose) {
            print num " failed: Correct '" correct_prn "', got '" 
result "'";
+         if (url)
+           print "   "url""tst":"num;
          }
        }
       }



























... /// ... \\\ ...