[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 01/24] blkdebug: Use errp for read_config()
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v7 01/24] blkdebug: Use errp for read_config() |
Date: |
Fri, 20 Dec 2013 19:28:01 +0100 |
Use an Error variable in the read_config() function.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
block/blkdebug.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index ebc5f13..2eb2e8b 100644
--- a/block/blkdebug.c
+++ b/block/blkdebug.c
@@ -271,7 +271,7 @@ static void remove_rule(BlkdebugRule *rule)
g_free(rule);
}
-static int read_config(BDRVBlkdebugState *s, const char *filename)
+static int read_config(BDRVBlkdebugState *s, const char *filename, Error
**errp)
{
FILE *f;
int ret;
@@ -279,11 +279,14 @@ static int read_config(BDRVBlkdebugState *s, const char
*filename)
f = fopen(filename, "r");
if (f == NULL) {
+ error_setg_errno(errp, errno, "Could not read blkdebug config file");
return -errno;
}
ret = qemu_config_parse(f, config_groups, filename);
if (ret < 0) {
+ error_setg(errp, "Could not parse blkdebug config file");
+ ret = -EINVAL;
goto fail;
}
@@ -370,9 +373,8 @@ static int blkdebug_open(BlockDriverState *bs, QDict
*options, int flags,
/* Read rules from config file */
config = qemu_opt_get(opts, "config");
if (config) {
- ret = read_config(s, config);
- if (ret < 0) {
- error_setg_errno(errp, -ret, "Could not read blkdebug config
file");
+ ret = read_config(s, config, errp);
+ if (ret) {
goto fail;
}
}
--
1.8.5.1
- [Qemu-devel] [PATCH v7 00/24] blkdebug/blkverify: Allow QMP configuration, Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 01/24] blkdebug: Use errp for read_config(),
Max Reitz <=
- [Qemu-devel] [PATCH v7 02/24] blkdebug: Don't require sophisticated filename, Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 03/24] qdict: Add qdict_array_split(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 04/24] qapi: extend qdict_flatten() for QLists, Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 05/24] qemu-option: Add qemu_config_parse_qdict(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 06/24] blkdebug: Always call read_config(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 07/24] blkdebug: Use command-line in read_config(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 08/24] block: Allow reference for bdrv_file_open(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 09/24] block: Pass reference to bdrv_file_open(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 10/24] block: Allow block devices without files, Max Reitz, 2013/12/20