[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULLv2 15/25] acpi-build: fix array leak
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PULLv2 15/25] acpi-build: fix array leak |
Date: |
Thu, 8 Sep 2016 18:17:10 +0400 |
The free_ranges array is used as a temporary pointer array, the segment
should still be freed, however, it shouldn't free the elements themself.
Signed-off-by: Marc-André Lureau <address@hidden>
Tested-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
---
hw/i386/acpi-build.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index a26a4bb..433feba 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -789,7 +789,7 @@ static gint crs_range_compare(gconstpointer a,
gconstpointer b)
static void crs_replace_with_free_ranges(GPtrArray *ranges,
uint64_t start, uint64_t end)
{
- GPtrArray *free_ranges = g_ptr_array_new_with_free_func(crs_range_free);
+ GPtrArray *free_ranges = g_ptr_array_new();
uint64_t free_base = start;
int i;
@@ -813,7 +813,7 @@ static void crs_replace_with_free_ranges(GPtrArray *ranges,
g_ptr_array_add(ranges, g_ptr_array_index(free_ranges, i));
}
- g_ptr_array_free(free_ranges, false);
+ g_ptr_array_free(free_ranges, true);
}
/*
--
2.10.0
- [Qemu-devel] [PULLv2 07/25] tests: fix test-iov leaks, (continued)
- [Qemu-devel] [PULLv2 07/25] tests: fix test-iov leaks, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 08/25] tests: fix check-qom-interface leaks, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 06/25] tests: fix test-vmstate leaks, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 10/25] tests: fix leak in test-string-input-visitor, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 09/25] tests: fix check-qom-proplist leaks, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 11/25] portio: keep references on portio, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 12/25] pc: simplify passing qemu_irq, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 13/25] pc: don't leak a20_line, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 14/25] machine: use class base init generated name, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 16/25] tests: fix qom-test leaks, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 15/25] acpi-build: fix array leak,
Marc-André Lureau <=
- [Qemu-devel] [PULLv2 17/25] pc: free i8259, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 18/25] pc: keep gsi reference, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 20/25] ipmi: free extern timer, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 19/25] sd: free timer, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 22/25] tests: add qtest_add_data_func_full, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 23/25] tests: pc-cpu-test leaks fixes, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 21/25] bus: simplify name handling, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 24/25] tests: fix rsp leak in postcopy-test, Marc-André Lureau, 2016/09/08
- [Qemu-devel] [PULLv2 25/25] tests: fix postcopy-test leaks, Marc-André Lureau, 2016/09/08
- Re: [Qemu-devel] [PULLv2 00/25] Leak patches, Peter Maydell, 2016/09/09