[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null chec
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null check |
Date: |
Tue, 5 Mar 2019 13:23:59 +0000 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
* Dr. David Alan Gilbert (git) (address@hidden) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> If the migration fails before the channel is open (e.g. a bad
> address) we end up in the cleanup with rdma->channel==NULL.
>
> Spotted by Coverity: CID 1398634
> Fixes: fbbaacab2758cb3f32a0
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Queued
> ---
> migration/rdma.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/migration/rdma.c b/migration/rdma.c
> index 54a3c11540..9fa3b176eb 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -2321,7 +2321,9 @@ static void qemu_rdma_cleanup(RDMAContext *rdma)
> rdma->connected = false;
> }
>
> - qemu_set_fd_handler(rdma->channel->fd, NULL, NULL, NULL);
> + if (rdma->channel) {
> + qemu_set_fd_handler(rdma->channel->fd, NULL, NULL, NULL);
> + }
> g_free(rdma->dest_blocks);
> rdma->dest_blocks = NULL;
>
> --
> 2.20.1
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null check,
Dr. David Alan Gilbert <=