[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icel
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model |
Date: |
Mon, 23 Mar 2020 14:39:36 -0400 |
On Mon, Mar 23, 2020 at 10:58:16AM +0800, Xiaoyao Li wrote:
> On 3/23/2020 10:32 AM, Tao Xu wrote:
> > Hi Xiaoyao,
> >
> > May be you can add .note for this new version.
> >
> > for example:
> >
> > + .version = 3,
> > + .note = "ARCH_CAPABILITIES",
> > + .props = (PropValue[]) {
>
> Hi Paolo and Eduardo,
>
> Need I spin a new version to add the .note ?
> Maybe you can add it when queue?
Please send a follow up patch so we don't hold a bug fix because
of something that's just cosmetic. I will queue this patch. We
still need a new version of "target/i386: Add notes for versioned
CPU models"[1], don't we?
[1] https://lore.kernel.org/qemu-devel/address@hidden/
--
Eduardo