Re: [PATCH v2] coreaudio: Lock only the buffer

[no-reply]

Patchew URL: 
20210622201740.38005-1-akihiko.odaki@gmail.com/">https://patchew.org/QEMU/20210622201740.38005-1-akihiko.odaki@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210622201740.38005-1-akihiko.odaki@gmail.com
Subject: [PATCH v2] coreaudio: Lock only the buffer

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210608040532.56449-1-ma.mandourr@gmail.com -> 
patchew/20210608040532.56449-1-ma.mandourr@gmail.com
 - [tag update]      patchew/20210621103337.36637-1-eesposit@redhat.com -> 
patchew/20210621103337.36637-1-eesposit@redhat.com
 * [new tag]         patchew/20210622201740.38005-1-akihiko.odaki@gmail.com -> 
patchew/20210622201740.38005-1-akihiko.odaki@gmail.com
 * [new tag]         patchew/20210622201923.150205-1-borntraeger@de.ibm.com -> 
patchew/20210622201923.150205-1-borntraeger@de.ibm.com
Switched to a new branch 'test'
6c7537d coreaudio: Lock only the buffer

=== OUTPUT BEGIN ===
ERROR: space prohibited between function name and open parenthesis '('
#58: FILE: audio/coreaudio.c:245:
+static int coreaudio_buf_lock (coreaudioVoiceOut *core, const char *fn_name)

ERROR: space prohibited between function name and open parenthesis '('
#63: FILE: audio/coreaudio.c:249:
+    err = pthread_mutex_lock (&core->buf_mutex);

ERROR: space prohibited between function name and open parenthesis '('
#72: FILE: audio/coreaudio.c:258:
+static int coreaudio_buf_unlock (coreaudioVoiceOut *core, const char *fn_name)

ERROR: space prohibited between function name and open parenthesis '('
#77: FILE: audio/coreaudio.c:262:
+    err = pthread_mutex_unlock (&core->buf_mutex);

ERROR: space prohibited between function name and open parenthesis '('
#114: FILE: audio/coreaudio.c:314:
+    if (coreaudio_buf_lock (core, "audioDeviceIOProc")) {

ERROR: space prohibited between function name and open parenthesis '('
#121: FILE: audio/coreaudio.c:320:
+        coreaudio_buf_unlock (core, "audioDeviceIOProc(old device)");

ERROR: space prohibited between function name and open parenthesis '('
#130: FILE: audio/coreaudio.c:330:
+        coreaudio_buf_unlock (core, "audioDeviceIOProc(empty)");

ERROR: space prohibited between function name and open parenthesis '('
#139: FILE: audio/coreaudio.c:352:
+    coreaudio_buf_unlock (core, "audioDeviceIOProc");

total: 8 errors, 0 warnings, 237 lines checked

Commit 6c7537d704dd (coreaudio: Lock only the buffer) has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210622201740.38005-1-akihiko.odaki@gmail.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210622201740.38005-1-akihiko.odaki@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com