Re: [PATCH v4 3/3] meson: generate trace events for qmp commands

[Vladimir Sementsov-Ogievskiy]

25.01.2022 14:03, Vladimir Sementsov-Ogievskiy wrote:
> 25.01.2022 13:25, Markus Armbruster wrote:
> > Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> >
> > > 1. Add --no-trace-events to suppress trace events generation in some
> > >     cases, and make trace events be generated by default.
> > > 2. Add corresponding .trace-events files as outputs in qapi_files
> > >     custom target
> > > 3. Define global qapi_trace_events list of .trace-events file targets,
> > >     to fill in trace/qapi.build and to use in trace/meson.build
> > > 4. In trace/meson.build use the new array as an additional source of
> > >     .trace_events files to be processed
> > >
> > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > > ---
> > >   docs/devel/qapi-code-gen.rst | 23 +++++++++++++++++++++--
> >
> > The doc update isn't mentioned in the commit message.
> >
> > >   meson.build                  |  3 +++
> > >   qapi/meson.build             |  7 +++++++
> > >   qga/meson.build              | 11 ++++++++++-
> > >   scripts/qapi/main.py         | 10 +++++++---
> > >   tests/meson.build            | 11 ++++++++++-
> > >   trace/meson.build            | 11 ++++++++---
> > >   7 files changed, 66 insertions(+), 10 deletions(-)
> >
> > This commit consists of a small QAPI code generator change, build system
> > work to put it to use, and QAPI documentation update for the series'
> > feature.
> >
> > I'd reshuffle as follows:
> >
> > * Squash the main.py change into the previous commit.
> >
> > * Split off the doc update into its own commit.
> >
> > This way, build system experts can provide an R-by in good conscience
> > without reviewing the doc update, and vice versa.
>
> But I think this way build will fail on previous commit. Or we should still 
> keep trace-generation disabled in previous commit, and enable it only together 
> with meson changes.

May be keep positive option --gen-trace-events in previous commit, like in my 
previous version? This way meson-changing commit becomes self-sufficient. And 
then in additional commit change the default and drop --gen-trace-events option 
and add --no-trace-events instead.

--
Best regards,
Vladimir