Re: [RFC PATCH 11/15] exec/cpu: Make address_space_init/reloading_memory_map target agnostic

[Philippe Mathieu-Daudé]

On 26/5/21 21:01, Richard Henderson wrote:
> On 5/17/21 4:55 AM, Philippe Mathieu-Daudé wrote:
> > cpu_address_space_init() and cpu_reloading_memory_map() don't
> > have to be target specific. Remove this limitation to be able
> > to build softmmu/cpus.c once for all targets.
> >
> > Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> > ---
> >   include/exec/cpu-common.h | 23 +++++++++++++++++++++++
> >   include/exec/exec-all.h   | 25 -------------------------
> >   2 files changed, 23 insertions(+), 25 deletions(-)
>
> It's not clear to me why the declarations moved file, instead of just 
> droppig the surrounding ifdef.
>
> If there's a good reason, fine, but the reason belongs in the commit 
> message.

What about:

'''
cpu_address_space_init() and cpu_reloading_memory_map() are
target-agnostic, but are declared in "exec/exec-all.h" which
contains target-specific declarations. Any target-agnostic
source including "exec/exec-all.h" becomes target-specific
and we have to compile it N times for the N targets built.
In order to avoid that, move the declarations to "exec/cpu-common.h"
which only contains target-agnostic declarations.
'''