Re: [PATCH v3] win32: set threads name

[Marc-André Lureau]

Hi

On Fri, Sep 30, 2022 at 6:10 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 9/30/22 07:03, marcandre.lureau@redhat.com wrote:
> > +static bool
> > +set_thread_description(HANDLE h, const char *name)
> > +{
> > +  HRESULT hr;
> > +  g_autofree wchar_t *namew = NULL;
> > +
> > +  if (!load_set_thread_description()) {
> > +      return false;
> > +  }
>
> I don't understand why you're retaining this.
> What is your logic?
>

Also, if we change the "static bool name_threads" to be true by
default, then set_thread_description() might be called without calling
qemu_thread_naming()

It really shouldn't hurt to keep it that way.