[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] gtk: Add show_menubar=on|off command line option.
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2] gtk: Add show_menubar=on|off command line option. |
Date: |
Wed, 12 Oct 2022 10:56:16 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Cc'ing maintainers. Doing that reduces the risk of maintainers missing
your patch. You can use scripts/get_maintainer.pl to find them.
Bryce Mills <brycemills@proton.me> writes:
> The patch adds "show_menubar" command line option for GTK UI similar to
> "show_tabs". This option allows to hide menu bar initially, it still can
> be toggled by shortcut and other shortcuts still work.
>
> Signed-off-by: Bryce Mills <brycemills@proton.me>
> ---
> qapi/ui.json | 5 ++++-
> qemu-options.hx | 3 +++
> ui/gtk.c | 15 ++++++++++-----
> 3 files changed, 17 insertions(+), 6 deletions(-)
>
> diff --git a/qapi/ui.json b/qapi/ui.json
> index 286c5731d1..0abba3e930 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -1199,13 +1199,16 @@
> # interfaces (e.g. VGA and virtual console character devices)
> # by default.
> # Since 7.1
> +# @show-menubar: Display the main window menubar. Defaults to "on".
> +# Since 8.0
> #
> # Since: 2.12
> ##
> { 'struct' : 'DisplayGTK',
> 'data' : { '*grab-on-hover' : 'bool',
> '*zoom-to-fit' : 'bool',
> - '*show-tabs' : 'bool' } }
> + '*show-tabs' : 'bool',
> + '*show-menubar' : 'bool' } }
>
> ##
> # @DisplayEGLHeadless:
QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>
[...]