Re: [PATCH v2 02/11] migration: Add support for 'file:' uri for incoming migration

[Daniel P . Berrangé]

On Mon, Oct 10, 2022 at 04:33:59PM +0300, Nikolay Borisov wrote:
> This is a counterpart to the 'file:' uri support for source migration,
> now a file can also serve as the source of an incoming migration.

As with the prvious patch, can we add a reminder:

  Unlike other migration protocol backends, the 'file' protocol cannot
  honour non-blocking mode. POSIX file/block storage will always report
  ready to read/write, regardless of how slow the underlying storage
  will be at servicing the request.

  For incoming migration this limitation may result in the main event
  loop not being fully responsive while loading the VM state. This
  won't impact the VM since it is not running at this phase, however,
  it may impact management applications.

> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
>  migration/file.c      | 15 +++++++++++++++
>  migration/file.h      |  1 +
>  migration/migration.c |  2 ++
>  3 files changed, 18 insertions(+)


> diff --git a/migration/migration.c b/migration/migration.c
> index 8813b78b9a6b..140b0f1a54bd 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -506,6 +506,8 @@ static void qemu_start_incoming_migration(const char 
> *uri, Error **errp)
>          exec_start_incoming_migration(p, errp);
>      } else if (strstart(uri, "fd:", &p)) {
>          fd_start_incoming_migration(p, errp);
> +    } else if (strstart(uri, "file:", &p)) {
> +     file_start_incoming_migration(p, errp);

A <tab> crept in there by mistake.

>      } else {
>          error_setg(errp, "unknown migration protocol: %s", uri);
>      }

With the above fixed

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|