[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] hw/block/nvme: supply dw1 for aen result
From: |
Klaus Jensen |
Subject: |
Re: [PATCH 3/4] hw/block/nvme: supply dw1 for aen result |
Date: |
Fri, 21 Oct 2022 07:59:26 +0200 |
On Okt 20 17:18, clay.mayers@kioxia.com wrote:
> From: Clay Mayers <clay.mayers@kioxia.com>
>
> cqe.dw1 AEN is sometimes required to convey the NSID of the log page
> to read. This is the case for the zone descriptor changed log
> page.
>
> Signed-off-by: Clay Mayers <clay.mayers@kioxia.com>
> ---
> hw/nvme/ctrl.c | 19 +++++++++++--------
> hw/nvme/nvme.h | 2 ++
> hw/nvme/trace-events | 2 +-
> include/block/nvme.h | 4 +++-
> 4 files changed, 17 insertions(+), 10 deletions(-)
>
> diff --git a/hw/nvme/nvme.h b/hw/nvme/nvme.h
> index ae65226150..2b7997e4a7 100644
> --- a/hw/nvme/nvme.h
> +++ b/hw/nvme/nvme.h
> @@ -477,6 +477,8 @@ typedef struct NvmeCtrl {
> uint64_t dbbuf_eis;
> bool dbbuf_enabled;
>
> + bool zdc_event_queued;
> +
> struct {
> MemoryRegion mem;
> uint8_t *buf;
Looks unrelated to this patch.
Otherwise,
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
signature.asc
Description: PGP signature
- [PATCH 0/4] hw/block/nvme: Implement ZNS finish-zone ZDC AEN, clay.mayers, 2022/10/20
- [PATCH 1/4] hw/block/nvme: add ZONE_FINISH_RECOMMENDED functionality, clay.mayers, 2022/10/20
- [PATCH 2/4] hw/block/nvme: add zone descriptor changed log page, clay.mayers, 2022/10/20
- [PATCH 4/4] hw/block/nvme: add zone descriptor changed AEN, clay.mayers, 2022/10/20
- [PATCH 3/4] hw/block/nvme: supply dw1 for aen result, clay.mayers, 2022/10/20
- Re: [PATCH 3/4] hw/block/nvme: supply dw1 for aen result,
Klaus Jensen <=
- Re: [PATCH 0/4] hw/block/nvme: Implement ZNS finish-zone ZDC AEN, Klaus Jensen, 2022/10/21