[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 24/28] qapi transaction: Elide redundant has_FOO in generated C
From: |
Markus Armbruster |
Subject: |
[PULL 24/28] qapi transaction: Elide redundant has_FOO in generated C |
Date: |
Tue, 25 Oct 2022 10:05:37 +0200 |
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/transaction.json.
Said commit explains the transformation in more detail. The invariant
violations mentioned there do not occur here.
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Hanna Reitz <hreitz@redhat.com>
Cc: qemu-block@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221018062849.3420573-25-armbru@redhat.com>
---
blockdev.c | 3 +--
scripts/qapi/schema.py | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 6a3b8cdbc6..0900a38ca6 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1048,7 +1048,7 @@ static void blockdev_do_action(TransactionAction *action,
Error **errp)
list.value = action;
list.next = NULL;
- qmp_transaction(&list, false, NULL, errp);
+ qmp_transaction(&list, NULL, errp);
}
void qmp_blockdev_snapshot_sync(const char *device, const char *node_name,
@@ -2288,7 +2288,6 @@ static TransactionProperties *get_transaction_properties(
* Always run under BQL.
*/
void qmp_transaction(TransactionActionList *dev_list,
- bool has_props,
struct TransactionProperties *props,
Error **errp)
{
diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
index f0726af876..3673296ad8 100644
--- a/scripts/qapi/schema.py
+++ b/scripts/qapi/schema.py
@@ -759,7 +759,6 @@ def need_has(self):
assert self.type
# Temporary hack to support dropping the has_FOO in reviewable chunks
opt_out = [
- 'qapi/transaction.json',
'qapi/ui.json',
'qapi/virtio.json',
'qga/qapi-schema.json']
--
2.37.3
- [PULL 14/28] qapi migration: Elide redundant has_FOO in generated C, (continued)
- [PULL 14/28] qapi migration: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/25
- [PULL 05/28] qapi tests: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/25
- [PULL 06/28] qapi acpi: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/25
- [PULL 02/28] qapi: Tidy up whitespace in generated code, Markus Armbruster, 2022/10/25
- [PULL 10/28] qapi crypto: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/25
- [PULL 12/28] qapi job: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/25
- [PULL 15/28] qapi misc: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/25
- [PULL 28/28] qapi: Drop temporary logic to support conversion step by step, Markus Armbruster, 2022/10/25
- [PULL 17/28] qapi pci: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/25
- [PULL 27/28] qapi qga: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/25
- [PULL 24/28] qapi transaction: Elide redundant has_FOO in generated C,
Markus Armbruster <=
- [PULL 03/28] docs/devel/qapi-code-gen: Extend example for next commit's change, Markus Armbruster, 2022/10/25
- [PULL 09/28] qapi chardev: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/25
- [PULL 23/28] qapi tpm: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/25
- [PULL 16/28] qapi net: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/25
- [PULL 21/28] qapi run-state: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/25
- [PULL 22/28] qapi stats: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/25
- Re: [PULL 00/28] QAPI patches patches for 2022-10-25, Stefan Hajnoczi, 2022/10/25
- Re: [PULL 00/28] QAPI patches patches for 2022-10-25, Stefan Hajnoczi, 2022/10/25