qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 23/24] vmdk: switch to *_co_* functions


From: Kevin Wolf
Subject: Re: [PATCH 23/24] vmdk: switch to *_co_* functions
Date: Thu, 27 Oct 2022 19:07:44 +0200

Am 13.10.2022 um 14:37 hat Paolo Bonzini geschrieben:
> From: Alberto Faria <afaria@redhat.com>
> 
> Signed-off-by: Alberto Faria <afaria@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

> @@ -1624,12 +1624,11 @@ static int coroutine_fn 
> get_cluster_offset(BlockDriverState *bs,
>      }
>      l2_table = (char *)extent->l2_cache + (min_index * l2_size_bytes);
>      BLKDBG_EVENT(extent->file, BLKDBG_L2_LOAD);
> -    if (bdrv_pread(extent->file,
> +    if (bdrv_co_pread(extent->file,
>                  (int64_t)l2_offset * 512,
>                  l2_size_bytes,
> -                l2_table,
> -                0
> -            ) < 0) {
> +                l2_table, 0
> +            ) != l2_size_bytes) {

Another incorrect conflict resolution, this would revert part of commit
353a5d84b25. Fixing it up as well.

Kevin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]