[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [QEMU][PATCH v2 4/5] tests/qtest: Introduce tests for Xilinx VERSAL
From: |
Peter Maydell |
Subject: |
Re: [QEMU][PATCH v2 4/5] tests/qtest: Introduce tests for Xilinx VERSAL CANFD controller |
Date: |
Thu, 10 Nov 2022 17:10:10 +0000 |
On Sat, 22 Oct 2022 at 07:20, Vikram Garhwal <vikram.garhwal@amd.com> wrote:
>
> The QTests perform three tests on the Xilinx VERSAL CANFD controller:
> Tests the CANFD controllers in loopback.
> Tests the CANFD controllers in normal mode with CAN frame.
> Tests the CANFD controllers in normal mode with CANFD frame.
>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
> Acked-by: Thomas Huth <thuth@redhat.com>
> +#include "qemu/osdep.h"
> +#include "libqtest.h"
> +
> +/* Base address. */
> +#define CANFD0_BASE_ADDR 0xFF060000
> +#define CANFD1_BASE_ADDR 0xFF070000
> +
> +/* Register addresses. */
> +#define R_SRR_OFFSET 0x00
> +#define R_MSR_OFFSET 0x04
> +#define R_FILTER_CONTROL_REGISTER 0xe0
> +#define R_SR_OFFSET 0x18
> +#define R_ISR_OFFSET 0x1C
Please be consistent about whether you do or don't capitalize the
A-F in hex values. Mostly we use lowercase, but upper vs lower
matters less than being consistent within the file at least.
thanks
-- PMM