qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 32/40] target/arm: Move "midr" to class property


From: Philippe Mathieu-Daudé
Subject: Re: [RFC PATCH 32/40] target/arm: Move "midr" to class property
Date: Thu, 5 Jan 2023 23:18:49 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1

On 3/1/23 19:16, Richard Henderson wrote:
With the movement of the property, we can remove the field
from the cpu entirely, using only the class.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  target/arm/cpu.h      |  1 -
  hw/arm/xilinx_zynq.c  |  9 ++++++---
  hw/intc/armv7m_nvic.c |  2 +-
  target/arm/cpu.c      | 18 ++++++++++++++++--
  target/arm/helper.c   | 14 ++++++++------
  5 files changed, 31 insertions(+), 13 deletions(-)

Lovely.

Perhaps later arm_class_prop_uint64_ofs() can grow into a generic
QOM TYPE macro.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]