Re: [PATCH 2/3] softmmu/ioport.c: QOMify MemoryRegionPortioList

[Paolo Bonzini]

On 5/11/23 16:43, Mark Cave-Ayland wrote:
> > > +#define TYPE_MEMORY_REGION_PORTIO_LIST "memory-region-portio-list"
> >
> > Possibly simpler as: TYPE_MEMORY_REGION_PORTIO "memory-region-portio"
>
> I'm a little undecided about this one: the ports field contains an array 
> of MemoryRegionPortio entries e.g. 
> https://gitlab.com/qemu-project/qemu/-/blob/master/hw/ide/ioport.c#L31 
> so I considered that the QOM object contains a list of 
> MemoryRegionPortios. TYPE_MEMORY_REGION_PORTIO_LIST feels a better fit 
> here since it reflects this whilst also matching the existing 
> MemoryRegionPortioList struct name.

I agree, using memory-region-portio would be confusing given the name of 
the struct.

Paolo