Re: [PATCH v4 10/10] accel/tcg: include cs_base in our hash calculations

[Richard Henderson]

On 5/23/23 05:50, Alex Bennée wrote:
>   static inline uint32_t qemu_xxhash5(uint64_t ab, uint64_t cd, uint32_t e)
>   {
> -    return qemu_xxhash7(ab, cd, e, 0, 0);
> +    return qemu_xxhash8(ab, cd, e, 0, 0);
>   }
>   
>   static inline uint32_t qemu_xxhash6(uint64_t ab, uint64_t cd, uint32_t e,
>                                       uint32_t f)
>   {
> -    return qemu_xxhash7(ab, cd, e, f, 0);
> +    return qemu_xxhash8(ab, cd, e, f, 0);
> +}

The last two arguments are 32 bit.  Better as

  qemu_xxhash8(ab, cd, 0, e, f);


r~