TCG broken on s390x hosts (was: [PULL 11/27] tcg/s390x: Support 128-bit load/store)

[Thomas Huth]

On 30/05/2023 20.59, Richard Henderson wrote:
> Use LPQ/STPQ when 16-byte atomicity is required.
> Note that these instructions require 16-byte alignment.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/s390x/tcg-target-con-set.h |   2 +
>   tcg/s390x/tcg-target.h         |   2 +-
>   tcg/s390x/tcg-target.c.inc     | 107 ++++++++++++++++++++++++++++++++-
>   3 files changed, 107 insertions(+), 4 deletions(-)

 Hi Richard!

I think this patch broke something on s390x hosts. I currently
cannot run the BootLinuxS390X.test_s390_ccw_virtio_tcg avocado
test on a s390x host - it times out:

 make check-venv
 ./tests/venv/bin/avocado run -t arch:s390x \
  tests/avocado/boot_linux.py:BootLinuxS390X.test_s390_ccw_virtio_tcg

... gets INTERRUPTED after the timeout expired.

It used to work fine in the past, so I bisected the problem
and it seems like 4caad79f8d60a5df20ceed1c396724af745c9512
is the first bad commit. If I revert it on top of the master
branch, the test works fine again. Could you please have
a look?

 Thanks,
  Thomas