Re: [PULL 20/47] linux-user: Make sure initial brk(0) is page-aligned

[Michael Tokarev]

17.07.2023 17:42, Richard Henderson пишет:
> On 7/16/23 19:15, Michael Tokarev wrote:
> > 15.07.2023 16:52, Richard Henderson wrote:
> > > From: Andreas Schwab <schwab@suse.de>
> > >
> > > Fixes: 86f04735ac ("linux-user: Fix brk() to release pages")
> > > Signed-off-by: Andreas Schwab <schwab@suse.de>
> > > Message-Id: <mvmpm55qnno.fsf@suse.de>
> > > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> >
> > This smells like a stable-8.0 material.  Please let me know if it is not.
>
> Yep.

FWIW, there was an attempt to fix another issue I posted about
yesterday, with libklibc-based apps on armhf, after "linux-user:
Reserve space for brk" commit, here:

  https://github.com/hdeller/qemu-hppa/commits/upx-fix

(which reverts this very commit).  But apparently it doesn't fix
that issue, libklibc-linked armhf apps still segfaults right at
startup.

This is jfyi, maybe this commit is just another temporary band-aid,
I dunno yet.  Yes it fixes real failures so it's already good.

Thanks,

/mjt