[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH QEMU v9 2/9] qapi/migration: Introduce x-vcpu-dirty-limit-per
From: |
Markus Armbruster |
Subject: |
Re: [PATCH QEMU v9 2/9] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter |
Date: |
Mon, 24 Jul 2023 11:26:20 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
~hyman <hyman@git.sr.ht> writes:
> From: Hyman Huang(黄勇) <yong.huang@smartx.com>
>
> Introduce "x-vcpu-dirty-limit-period" migration experimental
> parameter, which is in the range of 1 to 1000ms and used to
> make dirty page rate calculation period configurable.
>
> Currently with the "x-vcpu-dirty-limit-period" varies, the
Currently, as the ...
> total time of live migration changes, test results show the
Suggest period instead of comma.
> optimal value of "x-vcpu-dirty-limit-period" ranges from
> 500ms to 1000 ms. "x-vcpu-dirty-limit-period" should be made
> stable once it proves best value can not be determined with
> developer's experiments.
>
> Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
This commit message wordsmithing doesn't justify yet another respin by
itself. But if you need to respin the series for some other reason,
please consider my suggestions.
- [PATCH QEMU v9 0/9] migration: introduce dirtylimit capability, ~hyman, 2023/07/20
- [PATCH QEMU v9 1/9] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit", ~hyman, 2023/07/20
- [PATCH QEMU v9 7/9] migration: Implement dirty-limit convergence algorithm, ~hyman, 2023/07/20
- [PATCH QEMU v9 4/9] migration: Introduce dirty-limit capability, ~hyman, 2023/07/20
- [PATCH QEMU v9 3/9] qapi/migration: Introduce vcpu-dirty-limit parameters, ~hyman, 2023/07/20
- [PATCH QEMU v9 9/9] tests: Add migration dirty-limit capability test, ~hyman, 2023/07/20
- [PATCH QEMU v9 5/9] migration: Refactor auto-converge capability logic, ~hyman, 2023/07/20
- [PATCH QEMU v9 6/9] migration: Put the detection logic before auto-converge checking, ~hyman, 2023/07/20
- [PATCH QEMU v9 2/9] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter, ~hyman, 2023/07/20
- [PATCH QEMU v9 8/9] migration: Extend query-migrate to provide dirty-limit info, ~hyman, 2023/07/20