[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 1/5] qapi/block-core: Tidy up BlockLatencyHistogramInfo docume
From: |
Markus Armbruster |
Subject: |
Re: [PULL 1/5] qapi/block-core: Tidy up BlockLatencyHistogramInfo documentation |
Date: |
Wed, 26 Jul 2023 14:01:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
> On 26.07.23 14:28, Markus Armbruster wrote:
>> Documentation for member @bin comes out like
>> list of io request counts corresponding to histogram intervals.
>> len("bins") = len("boundaries") + 1 For the example above, "bins"
>> may be something like [3, 1, 5, 2], and corresponding histogram
>> looks like:
>>
>> Note how the equation and the sentence following it run together.
>> Replace the equation:
>>
>> list of io request counts corresponding to histogram intervals,
>> same number of elements as "boundaries". For the example above,
>
> not same, but one more. N points break the line into N+1 intervals
Thanks for catching this.
What about "one more element than @boundaries has"?
>> "bins" may be something like [3, 1, 5, 2], and corresponding
>> histogram looks like:
>> Cc: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> Message-ID: <20230720071610.1096458-2-armbru@redhat.com>