[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL for-8.1 1/8] block/blkio: enable the completion eventfd
From: |
Stefan Hajnoczi |
Subject: |
[PULL for-8.1 1/8] block/blkio: enable the completion eventfd |
Date: |
Thu, 27 Jul 2023 16:00:51 -0400 |
From: Stefano Garzarella <sgarzare@redhat.com>
Until libblkio 1.3.0, virtio-blk drivers had completion eventfd
notifications enabled from the start, but from the next releases
this is no longer the case, so we have to explicitly enable them.
In fact, the libblkio documentation says they could be disabled,
so we should always enable them at the start if we want to be
sure to get completion eventfd notifications:
By default, the driver might not generate completion events for
requests so it is necessary to explicitly enable the completion
file descriptor before use:
void blkioq_set_completion_fd_enabled(struct blkioq *q, bool enable);
I discovered this while trying a development version of libblkio:
the guest kernel hangs during boot, while probing the device.
Fixes: fd66dbd424f5 ("blkio: add libblkio block driver")
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Message-id: 20230725103744.77343-1-sgarzare@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/blkio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/blkio.c b/block/blkio.c
index 1798648134..bc1fac48b7 100644
--- a/block/blkio.c
+++ b/block/blkio.c
@@ -845,6 +845,7 @@ static int blkio_file_open(BlockDriverState *bs, QDict
*options, int flags,
QLIST_INIT(&s->bounce_bufs);
s->blkioq = blkio_get_queue(s->blkio, 0);
s->completion_fd = blkioq_get_completion_fd(s->blkioq);
+ blkioq_set_completion_fd_enabled(s->blkioq, true);
blkio_attach_aio_context(bs, bdrv_get_aio_context(bs));
return 0;
--
2.41.0
- [PULL for-8.1 0/8] Block patches, Stefan Hajnoczi, 2023/07/27
- [PULL for-8.1 1/8] block/blkio: enable the completion eventfd,
Stefan Hajnoczi <=
- [PULL for-8.1 2/8] block/blkio: do not use open flags in qemu_open(), Stefan Hajnoczi, 2023/07/27
- [PULL for-8.1 3/8] block/file-posix: fix g_file_get_contents return path, Stefan Hajnoczi, 2023/07/27
- [PULL for-8.1 4/8] block: Fix pad_request's request restriction, Stefan Hajnoczi, 2023/07/27
- [PULL for-8.1 6/8] block/blkio: retry blkio_connect() if it fails using `fd`, Stefan Hajnoczi, 2023/07/27
- [PULL for-8.1 7/8] block/blkio: fall back on using `path` when `fd` setting fails, Stefan Hajnoczi, 2023/07/27
- [PULL for-8.1 5/8] block/blkio: move blkio_connect() in the drivers functions, Stefan Hajnoczi, 2023/07/27
- [PULL for-8.1 8/8] block/blkio: use blkio_set_int("fd") to check fd support, Stefan Hajnoczi, 2023/07/27
- Re: [PULL for-8.1 0/8] Block patches, Richard Henderson, 2023/07/28