qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] target/s390x: Use a 16-bit immediate in VREP


From: David Hildenbrand
Subject: Re: [PATCH 1/2] target/s390x: Use a 16-bit immediate in VREP
Date: Mon, 7 Aug 2023 19:04:00 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

On 07.08.23 19:02, Ilya Leoshkevich wrote:
On Mon, 2023-08-07 at 19:00 +0200, David Hildenbrand wrote:
On 07.08.23 18:34, Ilya Leoshkevich wrote:
Unlike most other instructions that contain an immediate element
index,
VREP's one is 16-bit, and not 4-bit. The code uses only 8 bits, so
using, e.g., 0x101 does not lead to a specification exception.

Fix by checking all 16 bits.

Cc: qemu-stable@nongnu.org

Just curious, why stable? Are there valid programs that set invalid
element size and they are fixed by this?

None that I know of, but I thought this was still nice to have, and at
the same time small enough to not cause any trouble.

Yes, I was just curious. From my recollection, we didn't backport all specification exception checks.

--
Cheers,

David / dhildenb




reply via email to

[Prev in Thread] Current Thread [Next in Thread]