Re: [PATCH 10/33] Add struct target_freebsd_fhandle and fcntl flags to bsd-user/syscall_defs.h

[Warner Losh]

On Tue, Aug 8, 2023 at 3:26 PM Richard Henderson <richard.henderson@linaro.org> wrote:

On 8/7/23 23:07, Karim Taha wrote:
> +struct target_freebsd_fid {
> +    u_short     fid_len;            /* len of data in bytes */
> +    u_short     fid_data0;          /* force longword align */
> +    char        fid_data[TARGET_MAXFIDSZ];  /* data (variable len) */

uint16_t?

These were copied from FreeBSD's sys/mount.h... Changing to uint16_t likely

is a good idea, though. I'll handle the logistics of making changes like this in

bsd-user upstream with Kariim.

Warner

 

Otherwise,
Acked-by: Richard Henderson <richard.henderson@linaro.org>