Re: [PATCH 0/6] linux-user: Rewrite open_self_maps

[Helge Deller]

Hi Richard,

On 8/16/23 20:14, Richard Henderson wrote:
> Based-on: 20230816180338.572576-1-richard.henderson@linaro.org
> ("[PATCH v4 00/18] linux-user: Implement VDSOs")
>
> As promised, a rewrite of /proc/self/{maps,smaps} emulation
> using interval trees.
>
> Incorporate Helge's change to mark [heap], and also mark [vdso].

Series looks good, so you may add

Tested-by: Helge Deller <deller@gmx.de>

to this series and the previous one (linux-user: Implement VDSOs).


The only thing I noticed is, that mips64el doesn't seem to have heap?

mips64el-chroot
Linux p100 6.4.10-200.fc38.x86_64 #1 SMP PREEMPT_DYNAMIC Fri Aug 11 12:20:29 
UTC 2023 mips64 GNU/Linux
555555556000-555555557000 ---p 00000000 00:00 0
555555557000-555555d57000 rwxp 00000000 00:00 0                          [stack]
555555d57000-555555d84000 r-xp 00000000 fd:00 806056                     
/usr/lib/mips64el-linux-gnuabi64/ld.so.1
555555d84000-555555d96000 ---p 00000000 00:00 0
555555d96000-555555d97000 r--p 0002f000 fd:00 806056                     
/usr/lib/mips64el-linux-gnuabi64/ld.so.1
555555d97000-555555d99000 rw-p 00030000 fd:00 806056                     
/usr/lib/mips64el-linux-gnuabi64/ld.so.1
555555d99000-555555d9a000 r-xp 00000000 00:00 0
555555d9a000-555555d9c000 rw-p 00000000 00:00 0
555555da0000-555555f8a000 r-xp 00000000 fd:00 806059                     
/usr/lib/mips64el-linux-gnuabi64/libc.so.6
555555f8a000-555555f9a000 ---p 001ea000 fd:00 806059                     
/usr/lib/mips64el-linux-gnuabi64/libc.so.6
555555f9a000-555555fa0000 r--p 001ea000 fd:00 806059                     
/usr/lib/mips64el-linux-gnuabi64/libc.so.6
555555fa0000-555555fa5000 rw-p 001f0000 fd:00 806059                     
/usr/lib/mips64el-linux-gnuabi64/libc.so.6
555555fa5000-555555fb2000 rw-p 00000000 00:00 0
555555fbe000-5555560c0000 rw-p 00000000 00:00 0
7f9bc9987000-7f9bc9992000 r-xp 00000000 fd:00 811277                     
/usr/bin/cat
7f9bc9992000-7f9bc99a6000 ---p 00000000 00:00 0
7f9bc99a6000-7f9bc99a7000 r--p 0000f000 fd:00 811277                     
/usr/bin/cat
7f9bc99a7000-7f9bc99a8000 rw-p 00010000 fd:00 811277                     
/usr/bin/cat

Helge