Re: [PATCH 2/2] hw/misc/Kconfig: add switch for i2c-echo

[Thomas Huth]

On 23/08/2023 10.14, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Associate i2c-echo with TEST_DEVICES and add a dependency on I2C.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
>   hw/misc/Kconfig     | 5 +++++
>   hw/misc/meson.build | 2 +-
>   2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig
> index 6996d265e4c5..9ec7a40f973a 100644
> --- a/hw/misc/Kconfig
> +++ b/hw/misc/Kconfig
> @@ -34,6 +34,11 @@ config PCA9552
>       bool
>       depends on I2C
>   
> +config I2C_ECHO
> +    bool
> +    default y if TEST_DEVICES
> +    depends on I2C
> +
>   config PL310
>       bool
>   
> diff --git a/hw/misc/meson.build b/hw/misc/meson.build
> index 892f8b91c572..fbea23f8b27f 100644
> --- a/hw/misc/meson.build
> +++ b/hw/misc/meson.build
> @@ -132,7 +132,7 @@ system_ss.add(when: 'CONFIG_NRF51_SOC', if_true: 
> files('nrf51_rng.c'))
>   
>   system_ss.add(when: 'CONFIG_GRLIB', if_true: files('grlib_ahb_apb_pnp.c'))
>   
> -system_ss.add(when: 'CONFIG_I2C', if_true: files('i2c-echo.c'))
> +system_ss.add(when: 'CONFIG_I2C_ECHO', if_true: files('i2c-echo.c'))
>   
>   specific_ss.add(when: 'CONFIG_AVR_POWER', if_true: files('avr_power.c'))

Thanks, very appreciated!

Reviewed-by: Thomas Huth <thuth@redhat.com>