[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] migration/rdma: Fix save_page method to fail on polling
From: |
Eric Blake |
Subject: |
Re: [PATCH 1/7] migration/rdma: Fix save_page method to fail on polling error |
Date: |
Thu, 31 Aug 2023 08:38:09 -0500 |
User-agent: |
NeoMutt/20230517 |
On Thu, Aug 31, 2023 at 03:25:40PM +0200, Markus Armbruster wrote:
> qemu_rdma_save_page() reports polling error with error_report(), then
> succeeds anyway. This is because the variable holding the polling
> status *shadows* the variable the function returns. The latter
> remains zero.
>
> Broken since day one, and duplicated more recently.
>
> Fixes: 2da776db4846 (rdma: core logic)
> Fixes: b390afd8c50b (migration/rdma: Fix out of order wrid)
Alas, the curse of immutable git history preserving typos in commit
subjects ;) The alternative of rewriting history and breaking SHA
references is worse.
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> migration/rdma.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
- [PATCH 0/7] Steps towards enabling -Wshadow=local, Markus Armbruster, 2023/08/31
- [PATCH 5/7] block/vdi: Clean up local variable shadowing, Markus Armbruster, 2023/08/31
- [PATCH 4/7] block/dirty-bitmap: Clean up local variable shadowing, Markus Armbruster, 2023/08/31
- [PATCH 3/7] ui: Clean up local variable shadowing, Markus Armbruster, 2023/08/31
- [PATCH 1/7] migration/rdma: Fix save_page method to fail on polling error, Markus Armbruster, 2023/08/31
- [PATCH 2/7] migration: Clean up local variable shadowing, Markus Armbruster, 2023/08/31
- [PATCH 6/7] block: Clean up local variable shadowing, Markus Armbruster, 2023/08/31
- [PATCH 7/7] qobject atomics osdep: Make a few macros more hygienic, Markus Armbruster, 2023/08/31