[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output
From: |
Eric Blake |
Subject: |
Re: [PULL 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output |
Date: |
Fri, 8 Sep 2023 07:09:39 -0500 |
User-agent: |
NeoMutt/20230517 |
On Fri, Sep 08, 2023 at 01:42:00PM +0200, Denis V. Lunev wrote:
> On 9/8/23 13:24, Denis V. Lunev wrote:
> > On 9/8/23 13:03, Stefan Hajnoczi wrote:
> > > Please resolve the following CI failure:
> > >
> > > https://gitlab.com/qemu-project/qemu/-/jobs/5045998355
> > >
> > > ../qemu-nbd.c: In function 'nbd_client_thread':
> > > ../qemu-nbd.c:340:39: error: expected identifier before '(' token
> > > 340 | nbd_client_release_pipe(opts->stderr);
> > > | ^~~~~~
> The only possible reason I could imagine is that 'stderr'
> word is defined under by pre-processor.
Indeed, that is a common implementation; the obvious fix is to use a
different name. v2 coming up with that change made.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
- [PULL 06/13] util/iov: Avoid dynamic stack allocation, (continued)
- [PULL 06/13] util/iov: Avoid dynamic stack allocation, Eric Blake, 2023/09/07
- [PULL 08/13] qemu-nbd: define struct NbdClientOpts when HAVE_NBD_DEVICE is not defined, Eric Blake, 2023/09/07
- [PULL 09/13] qemu-nbd: move srcpath into struct NbdClientOpts, Eric Blake, 2023/09/07
- [PULL 10/13] qemu-nbd: put saddr into into struct NbdClientOpts, Eric Blake, 2023/09/07
- [PULL 11/13] qemu-nbd: invent nbd_client_release_pipe() helper, Eric Blake, 2023/09/07
- [PULL 13/13] qemu-nbd: document -v behavior in respect to --fork in man, Eric Blake, 2023/09/07
- [PULL 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output, Eric Blake, 2023/09/07