[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 07/12] tests/qtest/migration: Define a machine for all arc
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v4 07/12] tests/qtest/migration: Define a machine for all architectures |
Date: |
Thu, 19 Oct 2023 10:07:38 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Thomas Huth <thuth@redhat.com> writes:
> On 18/10/2023 21.27, Fabiano Rosas wrote:
>> Stop relying on defaults and select a machine explicitly for every
>> architecture.
>> This is a prerequisite for being able to select machine types for
>> migration using different QEMU binaries for source and destination.
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> ---
>> tests/qtest/migration-test.c | 16 +++++++++++++---
>> 1 file changed, 13 insertions(+), 3 deletions(-)
>> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
>> index e1c110537b..43d0b83771 100644
>> --- a/tests/qtest/migration-test.c
>> +++ b/tests/qtest/migration-test.c
[...]
>> @@ -829,12 +837,14 @@ static int test_migrate_start(QTestState **from,
>> QTestState **to,
>> }
>> cmd_target = g_strdup_printf("-accel kvm%s -accel tcg "
>> + "-machine %s,%s "
>
> If machine_opts is empty, there will be a lonely "," at the end of the
> parameter ... seems to work, but it's a little bit ugly.
keyval_parse() & friends accept trailing ',' to help with keeping things
simple.
> Anyway:
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
>
>> "-name target,debug-threads=on "
>> "-m %s "
>> "-serial file:%s/dest_serial "
>> "-incoming %s "
>> "%s %s %s %s %s",
>> kvm_opts ? kvm_opts : "",
>> + machine_alias, machine_opts,
>> memory_size, tmpfs, uri,
>> arch_opts ? arch_opts : "",
>> arch_target ? arch_target : "",
- [PATCH v4 01/12] tests/qtest: Allow qtest_qemu_binary to use a custom environment variable, (continued)
- [PATCH v4 01/12] tests/qtest: Allow qtest_qemu_binary to use a custom environment variable, Fabiano Rosas, 2023/10/18
- [PATCH v4 02/12] tests/qtest: Introduce qtest_init_with_env, Fabiano Rosas, 2023/10/18
- [PATCH v4 03/12] tests/qtest: Allow qtest_get_machines to use an alternate QEMU binary, Fabiano Rosas, 2023/10/18
- [PATCH v4 04/12] tests/qtest: Introduce qtest_has_machine_with_env, Fabiano Rosas, 2023/10/18
- [PATCH v4 05/12] tests/qtest: Introduce qtest_resolve_machine_alias, Fabiano Rosas, 2023/10/18
- [PATCH v4 06/12] tests/qtest/migration: Introduce find_common_machine_version, Fabiano Rosas, 2023/10/18
- [PATCH v4 07/12] tests/qtest/migration: Define a machine for all architectures, Fabiano Rosas, 2023/10/18
- [PATCH v4 08/12] tests/qtest/migration: Specify the geometry of the bootsector, Fabiano Rosas, 2023/10/18
- [PATCH v4 09/12] tests/qtest/migration: Set q35 as the default machine for x86_86, Fabiano Rosas, 2023/10/18
- [PATCH v4 10/12] tests/qtest/migration: Support more than one QEMU binary, Fabiano Rosas, 2023/10/18