Re: [PATCH 1/3] target/i386/hvf: Use CPUState typedef

[Zhao Liu]

On Fri, Oct 20, 2023 at 01:11:34PM +0200, Philippe Mathieu-Daudé wrote:
> Date: Fri, 20 Oct 2023 13:11:34 +0200
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH 1/3] target/i386/hvf: Use CPUState typedef
> X-Mailer: git-send-email 2.41.0
> 
> Follow C style guidelines and use CPUState forward
> declaration from "qemu/typedefs.h".
> 
> No functional changes.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  target/i386/hvf/x86_emu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

> 
> diff --git a/target/i386/hvf/x86_emu.c b/target/i386/hvf/x86_emu.c
> index b1f8a685d1..cd7ef30126 100644
> --- a/target/i386/hvf/x86_emu.c
> +++ b/target/i386/hvf/x86_emu.c
> @@ -45,7 +45,7 @@
>  #include "vmcs.h"
>  #include "vmx.h"
>  
> -void hvf_handle_io(struct CPUState *cpu, uint16_t port, void *data,
> +void hvf_handle_io(CPUState *cpu, uint16_t port, void *data,
>                     int direction, int size, uint32_t count);
>  
>  #define EXEC_2OP_FLAGS_CMD(env, decode, cmd, FLAGS_FUNC, save_res) \
> @@ -1417,7 +1417,7 @@ static void init_cmd_handler()
>      }
>  }
>  
> -void load_regs(struct CPUState *cpu)
> +void load_regs(CPUState *cpu)
>  {
>      X86CPU *x86_cpu = X86_CPU(cpu);
>      CPUX86State *env = &x86_cpu->env;
> @@ -1440,7 +1440,7 @@ void load_regs(struct CPUState *cpu)
>      env->eip = rreg(cpu->accel->fd, HV_X86_RIP);
>  }
>  
> -void store_regs(struct CPUState *cpu)
> +void store_regs(CPUState *cpu)
>  {
>      X86CPU *x86_cpu = X86_CPU(cpu);
>      CPUX86State *env = &x86_cpu->env;
> -- 
> 2.41.0
>