[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/20] parallels: Set s->used_bmap to NULL in parallels_fr
From: |
Mike Maslenkin |
Subject: |
Re: [PATCH v2 01/20] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap() |
Date: |
Sat, 21 Oct 2023 13:40:48 +0300 |
On Thu, Oct 19, 2023 at 4:06 PM Alexander Ivanov
<alexander.ivanov@virtuozzo.com> wrote:
>
> After used bitmap freeng s->used_bmap points to the freed memory. If we try
> to free used bitmap one more time it leads to double free error.
>
> Set s->used_bmap to NULL to exclude double free error.
>
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
> ---
> block/parallels.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/parallels.c b/block/parallels.c
> index 6b46623241..ba1fdde259 100644
> --- a/block/parallels.c
> +++ b/block/parallels.c
> @@ -244,6 +244,7 @@ static void parallels_free_used_bitmap(BlockDriverState
> *bs)
> {
> BDRVParallelsState *s = bs->opaque;
> s->used_bmap_size = 0;
> + s->used_bmap = NULL;
> g_free(s->used_bmap);
> }
Shouldn't it be added after g_free() call?
Regards,
Mike.
- [PATCH v2 00/20] parallels: Add full dirty bitmap support, Alexander Ivanov, 2023/10/19
- [PATCH v2 02/20] parallels: Move inactivation code to a separate function, Alexander Ivanov, 2023/10/19
- [PATCH v2 01/20] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap(), Alexander Ivanov, 2023/10/19
- Re: [PATCH v2 01/20] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap(),
Mike Maslenkin <=
- [PATCH v2 03/20] parallels: Add mark_unused() helper, Alexander Ivanov, 2023/10/19
- [PATCH v2 04/20] parallels: Move host clusters allocation to a separate function, Alexander Ivanov, 2023/10/19
- [PATCH v2 06/20] parallels: Recreate used bitmap in parallels_check_leak(), Alexander Ivanov, 2023/10/19
- [PATCH v2 08/20] parallels: Create used bitmap even if checks needed, Alexander Ivanov, 2023/10/19
- [PATCH v2 10/20] parallels: Add dirty bitmaps saving, Alexander Ivanov, 2023/10/19
- [PATCH v2 05/20] parallels: Set data_end value in parallels_check_leak(), Alexander Ivanov, 2023/10/19
- [PATCH v2 07/20] parallels: Add a note about used bitmap in parallels_check_duplicate(), Alexander Ivanov, 2023/10/19