[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 08/10] blockjob: query driver-specific info via a new 'query'
From: |
Fiona Ebner |
Subject: |
[PATCH v4 08/10] blockjob: query driver-specific info via a new 'query' driver method |
Date: |
Tue, 31 Oct 2023 14:54:29 +0100 |
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
No changes in v4.
blockjob.c | 6 ++++++
include/block/blockjob_int.h | 5 +++++
2 files changed, 11 insertions(+)
diff --git a/blockjob.c b/blockjob.c
index 9665b02627..41719dcf7d 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -376,6 +376,7 @@ BlockJobInfo *block_job_query_locked(BlockJob *job, Error
**errp)
{
BlockJobInfo *info;
uint64_t progress_current, progress_total;
+ const BlockJobDriver *drv = block_job_driver(job);
GLOBAL_STATE_CODE();
@@ -405,6 +406,11 @@ BlockJobInfo *block_job_query_locked(BlockJob *job, Error
**errp)
g_strdup(error_get_pretty(job->job.err)) :
g_strdup(strerror(-job->job.ret));
}
+ if (drv->query) {
+ job_unlock();
+ drv->query(job, info);
+ job_lock();
+ }
return info;
}
diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h
index a4656d4cb5..18ee6f7bf0 100644
--- a/include/block/blockjob_int.h
+++ b/include/block/blockjob_int.h
@@ -74,6 +74,11 @@ struct BlockJobDriver {
* Note that this can already be called before the job coroutine is
running.
*/
void (*change)(BlockJob *job, BlockJobChangeOptions *opts, Error **errp);
+
+ /*
+ * Query information specific to this kind of block job.
+ */
+ void (*query)(BlockJob *job, BlockJobInfo *info);
};
/*
--
2.39.2
- [PATCH v4 00/10] mirror: allow switching from background to active mode, Fiona Ebner, 2023/10/31
- [PATCH v4 01/10] blockjob: introduce block-job-change QMP command, Fiona Ebner, 2023/10/31
- [PATCH v4 05/10] mirror: implement mirror_change method, Fiona Ebner, 2023/10/31
- [PATCH v4 03/10] block/mirror: move dirty bitmap to filter, Fiona Ebner, 2023/10/31
- [PATCH v4 08/10] blockjob: query driver-specific info via a new 'query' driver method,
Fiona Ebner <=
- [PATCH v4 04/10] block/mirror: determine copy_to_target only once, Fiona Ebner, 2023/10/31
- [PATCH v4 02/10] block/mirror: set actively_synced even after the job is ready, Fiona Ebner, 2023/10/31
- [PATCH v4 06/10] qapi/block-core: use JobType for BlockJobInfo's type, Fiona Ebner, 2023/10/31
- [PATCH v4 10/10] iotests: add test for changing mirror's copy_mode, Fiona Ebner, 2023/10/31
- [PATCH v4 09/10] mirror: return mirror-specific information upon query, Fiona Ebner, 2023/10/31
- [PATCH v4 07/10] qapi/block-core: turn BlockJobInfo into a union, Fiona Ebner, 2023/10/31
- Re: [PATCH v4 00/10] mirror: allow switching from background to active mode, Kevin Wolf, 2023/10/31