RE: [PATCH v4 27/41] util/char_dev: Add open_cdev()

[Duan, Zhenzhong]

>-----Original Message-----
>From: Cédric Le Goater <clg@redhat.com>
>Sent: Tuesday, November 7, 2023 9:38 PM
>Subject: Re: [PATCH v4 27/41] util/char_dev: Add open_cdev()
>
>On 11/2/23 08:12, Zhenzhong Duan wrote:
>> From: Yi Liu <yi.l.liu@intel.com>
>>
>> /dev/vfio/devices/vfioX may not exist. In that case it is still possible
>> to open /dev/char/$major:$minor instead. Add helper function to abstract
>> the cdev open.
>>
>> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
>> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>> ---
>>   MAINTAINERS                 |  6 +++
>>   include/qemu/chardev_open.h | 16 ++++++++
>>   util/chardev_open.c         | 81 +++++++++++++++++++++++++++++++++++++
>>   util/meson.build            |  1 +
>>   4 files changed, 104 insertions(+)
>>   create mode 100644 include/qemu/chardev_open.h
>>   create mode 100644 util/chardev_open.c
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 6f35159255..eada773975 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3473,6 +3473,12 @@ S: Maintained
>>   F: include/qemu/iova-tree.h
>>   F: util/iova-tree.c
>>
>> +cdev Open
>> +M: Yi Liu <yi.l.liu@intel.com>
>> +S: Maintained
>> +F: include/qemu/chardev_open.h
>> +F: util/chardev_open.c
>
>May be move under the IOMMUFD entry instead ?

Sure, will do.

Thanks
Zhenzhong