Re: [PATCH v5 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase

[Philippe Mathieu-Daudé]

On 28/12/23 17:19, Inès Varhol wrote:
> Signed-off-by: Arnaud Minier <arnaud.minier@telecom-paris.fr>
> Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr>
> ---
>   tests/qtest/meson.build           |   5 +
>   tests/qtest/stm32l4x5_exti-test.c | 596 ++++++++++++++++++++++++++++++
>   2 files changed, 601 insertions(+)
>   create mode 100644 tests/qtest/stm32l4x5_exti-test.c

Once the SoC parentship fixed in based series, this patch
requires:

-- >8 --
diff --git a/tests/qtest/stm32l4x5_exti-test.c 
b/tests/qtest/stm32l4x5_exti-test.c
index 60c8297246..543199cd4d 100644
--- a/tests/qtest/stm32l4x5_exti-test.c
+++ b/tests/qtest/stm32l4x5_exti-test.c
@@ -287,4 +287,3 @@ static void test_edge_selector(void)
     /* Configure EXTI line 0 irq on rising edge */
-    qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
-                     NULL, 0, 1);
+    qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 1);
     exti_writel(EXTI_IMR1, 0x00000001);
@@ -294,4 +293,3 @@ static void test_edge_selector(void)
     /* Test that an irq is raised on rising edge only */
-    qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
-                     NULL, 0, 0);
+    qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 0);

@@ -301,4 +299,3 @@ static void test_edge_selector(void)

-    qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
-                     NULL, 0, 1);
+    qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 1);

@@ -316,4 +313,3 @@ static void test_edge_selector(void)
     /* Configure EXTI line 0 irq on falling edge */
-    qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
-                     NULL, 0, 0);
+    qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 0);
     exti_writel(EXTI_IMR1, 0x00000001);
@@ -323,4 +319,3 @@ static void test_edge_selector(void)
     /* Test that an irq is raised on falling edge only */
-    qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
-                     NULL, 0, 1);
+    qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 1);

@@ -330,4 +325,3 @@ static void test_edge_selector(void)

-    qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
-                     NULL, 0, 0);
+    qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 0);

@@ -350,4 +344,3 @@ static void test_edge_selector(void)
     /* Test that an irq is raised on rising and falling edge */
-    qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
-                     NULL, 0, 1);
+    qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 1);

@@ -357,4 +350,3 @@ static void test_edge_selector(void)

-    qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
-                     NULL, 0, 0);
+    qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 0);

@@ -377,4 +369,3 @@ static void test_edge_selector(void)
     /* Test that no irq is raised */
-    qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
-                     NULL, 0, 1);
+    qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 1);

@@ -384,4 +375,3 @@ static void test_edge_selector(void)

-    qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
-                     NULL, 0, 0);
+    qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 0, 0);

@@ -500,4 +490,3 @@ static void test_masked_interrupt(void)
     /* Simulate rising edge from GPIO line 1 */
-    qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
-                     NULL, 1, 1);
+    qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 1, 1);

@@ -550,4 +539,3 @@ static void test_interrupt(void)
     /* Simulate rising edge from GPIO line 1 */
-    qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
-                     NULL, 1, 1);
+    qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, 1, 1);
---

Note you could use a helper to ease readability:

static void exti_set_irq(int num, int lvl)
{
   qtest_set_irq_in(global_qtest, "/machine/soc/exti", NULL, num, lvl);
}

Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>