Re: [PATCH 19/24] configure: remove compiler sanity check

[Thomas Huth]

On 11/05/2023 11.50, Paolo Bonzini wrote:
> The comment is not correct anymore, in that the usability test for
> the compiler and linker are done after probing $cpu, and Meson will
> redo them anyway.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   configure | 14 --------------
>   1 file changed, 14 deletions(-)
>
> diff --git a/configure b/configure
> index 6e5e91908a4b..85f82a626964 100755
> --- a/configure
> +++ b/configure
> @@ -1090,20 +1090,6 @@ if test -z "$ninja"; then
>       fi
>   fi
>   
> -# Check that the C compiler works. Doing this here before testing
> -# the host CPU ensures that we had a valid CC to autodetect the
> -# $cpu var (and we should bail right here if that's not the case).
> -# It also allows the help message to be printed without a CC.
> -write_c_skeleton;
> -if compile_object ; then
> -  : C compiler works ok
> -else
> -    error_exit "\"$cc\" either does not exist or does not work"
> -fi
> -if ! compile_prog ; then
> -    error_exit "\"$cc\" cannot build an executable (is your linker broken?)"
> -fi
> -
>   # Consult white-list to determine whether to enable werror
>   # by default.  Only enable by default for git builds
>   if test -z "$werror" ; then

 Hi Paolo!

When running "configure" on a system without C compiler, the user is now 
presented with:

 ERROR: Unrecognized host OS (uname -s reports 'Linux')

That's completely unhelpful. Could we maybe revert this patch to get a 
better error message again?

 Thanks,
  Thomas