Re: [PATCH v3 00/16] tests: enable meson test timeouts to improve debuggability

[Peter Maydell]

On Tue, 23 Jan 2024 at 20:52, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> 23.01.2024 20:47, Thomas Huth:
> > On 23/01/2024 17.50, Michael Tokarev wrote:
> ..
>
> >> I'm picking this up for stable branches too, since there we have the same
> >> problems in CI environment. In particular, bios-tables-test almost always
> >> times out, even hitting retry doesn't help.  Let's see how it goes..
> >
> > Uh, wait, that does not make too much sense ... if bios-tables-test already 
> > times out *without* the additional meson-based timeouts, then adding the
> > meson timeouts won't help. bios-tables-test uses the manually coded timeout 
> > from boot_sector_test() that is currently set to 600 seconds. If you hit
> > that timeout, that likely means that something is really broken in your 
> > branch - or is it sometimes still succeeding?
>
> I mistyped the test name as I was dealing with bios-tables-test at that
> time in another context (unrelated).  Actual failing test in this case,
> among others, is avocado acpi_smbios_bits, eg
>   https://gitlab.com/qemu-project/qemu/-/jobs/5991505589#L231 which timed
> out on multiple attempts.  In this example it took a bit less than 65s.

The fix for that flakiness is commit 7ef4c41e91d59
("acpi/tests/avocado/bits: wait for 200 seconds for SHUTDOWN event
from bits VM").

thanks
-- PMM