Re: [PATCH v1 00/15] libvhost-user: support more memslots and cleanup memslot handling code

[David Hildenbrand]

On 13.02.24 19:55, Michael S. Tsirkin wrote:
> On Tue, Feb 13, 2024 at 07:27:44PM +0100, David Hildenbrand wrote:
> > On 13.02.24 18:33, Michael S. Tsirkin wrote:
> > > On Fri, Feb 02, 2024 at 10:53:17PM +0100, David Hildenbrand wrote:
> > > > This series adds support for more memslots (509) to libvhost-user, to
> > > > make it fully compatible with virtio-mem that uses up to 256 memslots
> > > > accross all memory devices in "dynamic-memslot" mode (more details
> > > > in patch #3).
> > >
> > >
> > > Breaks build on some systems. E.g.
> > > https://gitlab.com/mstredhat/qemu/-/jobs/6163591599
> >
> > ./subprojects/libvhost-user/libvhost-user.c:369:27: error: comparison of
> > integer expressions of different signedness: ‘long int’ and ‘unsigned int’
> > [-Werror=sign-compare]
> >    369 |     if (!ret && fs.f_type == HUGETLBFS_MAGIC) {
> >        |                           ^~
> >
> > So easy to fix in v2, thanks!
>
>
> I think there is another problem around plugins though.

There is a wrong checkpatch error:

https://gitlab.com/mstredhat/qemu/-/jobs/6162397277

d96f29518232719b0c444ab93913e8515a6cb5c6:100: ERROR: use 
qemu_real_host_page_size() instead of getpagesize()
total: 1 errors, 1 warnings, 81 lines checked

qemu_real_host_page_size() is not available in libvhost-user. But I 
could just change that code to not require getpagesize() at all.


Apart from that, I don't spot anything libvhost-user related (some qtest 
timeouts, a "error_setv: Assertion `*errp == NULL' failed."). Did I miss 
something?

--
Cheers,

David / dhildenb