Re: [PATCH v3 0/3] Add support for I2C in BCM2835 boards

[Peter Maydell]

On Fri, 23 Feb 2024 at 06:23, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Hi Peter,
>
> On 22/2/24 18:54, Peter Maydell wrote:
> > On Tue, 20 Feb 2024 at 13:42, Rayhan Faizel <rayhan.faizel@gmail.com> wrote:
> >>
> >> This patch series implements support for the Broadcom Serial Controller 
> >> used
> >> by BCM2835 based boards for I2C.
>
>
> >> Rayhan Faizel (3):
> >>    hw/i2c: Implement Broadcom Serial Controller (BSC)
> >>    hw/arm: Connect BSC to BCM2835 board as I2C0, I2C1 and I2C2
> >>    tests/qtest: Add testcase for BCM2835 BSC
> >
> >
> >
> > Applied to target-arm.next, thanks.
>
> Sorry I didn't notice earlier, the I2C[3] IRQ lines have
> to be OR-ed using a TYPE_OR_IRQ object before reaching the
> INTC. I'd rather a v4, but if you already posted your PR
> this can get fixed on top.

Oops, yes, you're right. I didn't notice that. I haven't yet
got to the point of making a pullreq, so I'll drop this series,
and send my r-by tags to the list for the other patches.

thanks
-- PMM