[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/10] hw/core: Add ResetContainer which holds objects implem
From: |
Peter Maydell |
Subject: |
Re: [PATCH 06/10] hw/core: Add ResetContainer which holds objects implementing Resettable |
Date: |
Mon, 26 Feb 2024 14:42:53 +0000 |
On Tue, 20 Feb 2024 at 21:20, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 20 Feb 2024 at 19:46, Richard Henderson
> <richard.henderson@linaro.org> wrote:
> >
> > On 2/20/24 06:06, Peter Maydell wrote:
> > > +void resettable_container_add(ResettableContainer *rc, Object *obj)
> > > +{
> > > + g_ptr_array_add(rc->children, obj);
> > > +}
> >
> > Did you want to assert here that obj does in fact implement Resettable?
>
> I guess that makes for a nicer detection of that class of bug,
> so sure.
I'm going to do this with
INTERFACE_CHECK(void, obj, TYPE_RESETTABLE_INTERFACE);
If anybody thinks there's a better way of doing that let me know.
-- PMM
[PATCH 04/10] include/qom/object.h: New OBJECT_DEFINE_SIMPLE_TYPE{, _WITH_INTERFACES} macros, Peter Maydell, 2024/02/20
[PATCH 07/10] hw/core/reset: Add qemu_{register, unregister}_resettable(), Peter Maydell, 2024/02/20