Re: [PATCH 1/4] ui/vc: Do not inherit the size of active console

[Marc-André Lureau]

On Mon, Mar 18, 2024 at 11:59 AM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> A chardev-vc used to inherit the size of a graphic console when its
> size not explicitly specified, but it often did not make sense. If a
> chardev-vc is instantiated during the startup, the active graphic
> console has no content at the time, so it will have the size of graphic
> console placeholder, which contains no useful information. It's better
> to have the standard size of text console instead.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  ui/console-vc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/console-vc.c b/ui/console-vc.c
> index 9c13cc2981b0..f22c8e23c2ed 100644
> --- a/ui/console-vc.c
> +++ b/ui/console-vc.c
> @@ -990,8 +990,8 @@ static void vc_chr_open(Chardev *chr,
>      trace_console_txt_new(width, height);
>      if (width == 0 || height == 0) {
>          s = QEMU_TEXT_CONSOLE(object_new(TYPE_QEMU_TEXT_CONSOLE));
> -        width = qemu_console_get_width(NULL, 80 * FONT_WIDTH);
> -        height = qemu_console_get_height(NULL, 24 * FONT_HEIGHT);
> +        width = 80 * FONT_WIDTH;
> +        height = 24 * FONT_HEIGHT;
>      } else {
>          s = QEMU_TEXT_CONSOLE(object_new(TYPE_QEMU_FIXED_TEXT_CONSOLE));
>      }
>
> --
> 2.44.0
>
>


-- 
Marc-André Lureau