tramp-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug in tramp.el


From: Patrick Tullmann
Subject: bug in tramp.el
Date: Fri, 2 Jan 2004 19:24:08 -0800
User-agent: Mutt/1.4i

In tramp.el in the 2.0.38 release there are three bogus(?) references
to "rsh-args".  I think if the specific port syntax is used ("#8022"),
these bogus variables are referenced.  (I was getting a "void as
variable" error.)

It looks like each needs to be replaced with the name of variable that
the "-p xxx" is being pre-pended to?  Perhaps now is the time to write
a common function to prepend the port number?  :)  

A patch is attached as that can probably better explain what I mean.

Thanks for writing this fabulous extension to x?emacs!

-Pat

----- ----- ---- ---  ---  --   -    -      -         -               -
Pat Tullmann                                     address@hidden
       It said "Windows 95 or better" so FreeBSD should run it.


--- tramp.el    2004-01-02 19:22:23.000000000 -0800
+++ tramp.el-fixed      2004-01-02 19:22:39.000000000 -0800
@@ -3071,7 +3071,7 @@
             ;; mechanism to parse extra host args.
             (when (string-match "\\([^#]*\\)#\\(.*\\)" host)
               (setq copy-args (cons "-p" (cons (match-string 2 host)
-                                               rsh-args)))
+                                               copy-args)))
               (setq host (match-string 1 host)))
             ;; Use rcp-like program for file transfer.
             (tramp-message-for-buffer
@@ -3272,7 +3272,7 @@
             ;; mechanism to parse extra host args.
             (when (string-match "\\([^#]*\\)#\\(.*\\)" host)
               (setq copy-args (cons "-p" (cons (match-string 2 host)
-                                               rsh-args)))
+                                               copy-args)))
               (setq host (match-string 1 host)))
 
             ;; use rcp-like program for file transfer
@@ -4768,7 +4768,7 @@
       ;; The following should be changed.  We need a more general
       ;; mechanism to parse extra host args.
       (when (string-match "\\([^#]*\\)#\\(.*\\)" host)
-       (setq login-args (cons "-p" (cons (match-string 2 host) rsh-args)))
+       (setq login-args (cons "-p" (cons (match-string 2 host) login-args)))
        (setq host (match-string 1 host)))
       (setenv "TERM" tramp-terminal-type)
       (let* ((default-directory (tramp-temporary-file-directory))




reply via email to

[Prev in Thread] Current Thread [Next in Thread]