Re: [Acl-devel] [PATCH] acl: use SHELL from configure

[Brandon Philips]

Applied to attr and acl. Thanks.
Brandon


On Tue, May 7, 2013 at 9:04 AM, Mike Frysinger <address@hidden> wrote:
> If /bin/sh is not a functional enough shell, configure will select a
> SHELL of /bin/bash or better.  But the current build helpers always
> hardcode /bin/sh, so if libtool itself configures itself for /bin/bash,
> things will fail when it attempts to do:
>         SHELL = /bin/sh
>         LIBTOOL = $(SHELL) .../libtool
>         ...
>         eval: 1: base_compile+= -pipe: not found
>         ...
>
> So rather than hardcoding SHELL to /bin/sh, set it to @SHELL@ and let
> configure find a good value for us.
>
> Signed-off-by: Mike Frysinger <address@hidden>
> ---
>  include/builddefs.in | 1 +
>  include/buildmacros  | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/builddefs.in b/include/builddefs.in
> index d054a56..434ce95 100644
> --- a/include/builddefs.in
> +++ b/include/builddefs.in
> @@ -46,6 +46,7 @@ MAKE          = @make@
>  ECHO           = @echo@
>  SORT           = @sort@
>  LN_S           = @LN_S@
> +SHELL          = @SHELL@
>  LIBTOOL                = @LIBTOOL@
>  MAKEDEPEND     = @makedepend@
>
> diff --git a/include/buildmacros b/include/buildmacros
> index ab89182..8efb32e 100644
> --- a/include/buildmacros
> +++ b/include/buildmacros
> @@ -42,7 +42,6 @@ OBJECTS = $(ASFILES:.s=.o) \
>
>  INSTALL        = $(TOPDIR)/include/install-sh -o $(PKG_USER) -g $(PKG_GROUP)
>
> -SHELL = /bin/sh
>  IMAGES_DIR = $(TOPDIR)/all-images
>  DIST_DIR = $(TOPDIR)/dist
>
> --
> 1.8.2.1
>
>